Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_router fee rate issue #323

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Nov 19, 2024

There is a bug that channel_update updated fee rate and build_router didn't applied the latest fee rate.

@chenyukang chenyukang marked this pull request as draft November 19, 2024 11:45
@chenyukang chenyukang marked this pull request as ready for review November 19, 2024 17:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.48%. Comparing base (feefe59) to head (385fa5a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/fiber/graph.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   46.47%   46.48%   +0.01%     
==========================================
  Files          45       45              
  Lines       28511    28518       +7     
==========================================
+ Hits        13251    13258       +7     
  Misses      15260    15260              
Flag Coverage Δ
unittests 46.48% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@quake quake merged commit 78a4da8 into nervosnetwork:main Nov 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants